Skip to content

chore: bring back json schemas to avoid a breaking change in schemastore and other third parties #4150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

chore: bring back json schemas to avoid a breaking change in schemastore and other third parties #4150

wants to merge 1 commit into from
+3,207 −3

Conversation

ThomasRooney
Copy link
Contributor

@ThomasRooney ThomasRooney commented Oct 21, 2024 •
edited
Loading

Closes #4149

Reverts a section of #4137 for reasons stated in #4149

@ThomasRooney ThomasRooney requested review from a team as code owners October 21, 2024 11:32
ralfhandl
ralfhandl reviewed Oct 21, 2024
View reviewed changes
schemas/v3.0/schema.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file was intentionally deleted, please use this URL

ralfhandl
ralfhandl reviewed Oct 21, 2024
View reviewed changes
schemas/v3.1/dialect/base.schema.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file was intentionally deleted, please use this URL

ralfhandl
ralfhandl reviewed Oct 21, 2024
View reviewed changes
schemas/v3.1/meta/base.schema.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file was intentionally deleted, please use this URL

ralfhandl
ralfhandl requested changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@ralfhandl ralfhandl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The schemas are all available at the same location as their $id or id says.

They were intentionally removed.

schemas/v3.1/schema-base.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file was intentionally deleted, please use this URL

lornajane
lornajane approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@lornajane lornajane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in favour of temporarily accepting this change and communicating with the projects that experienced issues about reinstating it.

@ThomasRooney
Copy link
Contributor Author

Schemastore, when updated, should automatically fix everything within a few days as the TTL is relatively low. I'm in favour of closing this PR.

@ThomasRooney
Copy link
Contributor Author

Closing this based on SchemaStore/schemastore#4159 fixing this in a safer way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ralfhandl ralfhandl ralfhandl requested changes

@lornajane lornajane lornajane approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

schema.json files were removed

3 participants

@ThomasRooney @lornajane @ralfhandl